Skip to content

Conversation

shin-
Copy link
Contributor

@shin- shin- commented Jan 5, 2016

  • Add unit tests for utils.parse_devices
  • Rewrite documentation
  • Support dict and string format for device declaration

Fixes #725

@shin- shin- added this to the 1.7.0 milestone Jan 5, 2016
@shin- shin- self-assigned this Jan 5, 2016
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also document the dict form of elements in the devices list?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added 👍

@shin- shin- force-pushed the 725-devices-format branch from ba0543e to 3a3f790 Compare January 18, 2016 19:34
Add unit tests for utils.parse_devices
Rewrite documentation
Support dict and string format for device declaration

Signed-off-by: Joffrey F <joffrey@docker.com>
@shin- shin- force-pushed the 725-devices-format branch from 3a3f790 to f9b04c1 Compare January 18, 2016 19:38
@aanand
Copy link
Contributor

aanand commented Jan 18, 2016

LGTM

aanand added a commit that referenced this pull request Jan 18, 2016
@aanand aanand merged commit 57b79cb into master Jan 18, 2016
@aanand aanand deleted the 725-devices-format branch January 18, 2016 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants