Implement support for network-scoped aliases #895
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docker/utils/utils.py
Outdated
There was a problem hiding this comment.
Yep, just anticipating future additions (these things have a tendency to grow), but it's probably unnecessary
|
Couple small nits, otherwise LGTM |
There was a problem hiding this comment.
How about leaving this here, and only adding requires('1.22') to the few methods where it's necessary?
There was a problem hiding this comment.
I wasn't sure if the two would interact weirdly, so I elected to be more explicit, but I don't have strong feelings about it
Signed-off-by: Aanand Prasad <aanand.prasad@gmail.com>
|
LGTM |
aanand
added a commit
that referenced
this pull request
Jan 14, 2016
Implement support for network-scoped aliases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing docs, but network docs are already lacking. Will fill them out in a follow-up PR.