Don't break when parsing unknown config keys #929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docker/auth/auth.py
Outdated
|
|
||
|
|
||
| def parse_auth(entries): | ||
| def parse_auth(entries, fail=False): |
There was a problem hiding this comment.
Minor: I think the kwarg could be slightly more verbose, maybe warn_on_error=True or raise_on_error=False ?
There was a problem hiding this comment.
Or considering this is only required for parsing the legacy config, maybe include_legacy=True ?
|
LGTM |
Signed-off-by: Joffrey F <joffrey@docker.com>
shin-
force-pushed
the
927-config-parsing
branch
from
b19d9ed to
dc198be
Compare
shin-
added a commit
that referenced
this pull request
Feb 9, 2016
Don't break when parsing unknown config keys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #927