Skip to content

Conversation

mnimm
Copy link
Contributor

@mnimm mnimm commented Jan 20, 2020

Make it clear that DCT does not protect against layer tampering on the docker host.

Proposed changes

The documentation suggests that DCT protects against changes to images on the local disk. However, it does not. DCT only protects against compromised repositories, but not against attacks on the local filesystem. So far, there was a warning that DCT does not protect RUNNING containers. However, it does not even protect any containers or images locally on a docker host. This should be clear so people do not make wrong assumptions leading to security issues.

Unreleased project version (optional)

Related issues (optional)

Make it clear that DCT does not protect against layer tampering on the docker host.
@mnimm mnimm mentioned this pull request Jan 20, 2020
@GordonTheTurtle
Copy link

Deploy preview for docsdocker ready!

Built with commit 27e529c

https://deploy-preview-10168--docsdocker.netlify.com

@mcandre
Copy link

mcandre commented Feb 4, 2020

I vote have docker run emit a warning, terminate prior to the image entrypoint, exit non-zero, and offer a CLI flag to forcibly override in the event of breaking digital signatures.

Would be helpful for docker-compose, Kubernetes et al to implement this behavior as well.

@mnimm
Copy link
Contributor Author

mnimm commented Feb 4, 2020

@mcandre: afaik the problem is that docker run cannot verify image signatures of locally cached images, because images get unpacked once they are pulled. So this is works-as-designed according to the Docker security team.
Also see my blogpost here: https://www.impidio.com/blog/manipulating-signed-docker-images

@mcandre
Copy link

mcandre commented Feb 4, 2020

Ah, okay.

In that case, Docker could maintain a mapping between those.

@usha-mandya
Copy link
Member

@mnimm Thanks for the update.

@usha-mandya usha-mandya merged commit 580bcb4 into docker:master Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants