-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Add note that docker builds are not always protected by ECI. #19900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Cesar Talledo <cesar.talledo@docker.com>
2fadfbd
to
665f4e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ctalledo, looks fine to me.
I noticed that limitations.md
is no longer visible in the table of content for some reason 🤔 . Would you mind adding it to the toc.yaml
file?
Signed-off-by: Cesar Talledo <cesar.talledo@docker.com>
Thanks Allie (@aevesdocker); yes I noticed that too, I think it used to be tab within the ECI FAQs doc, but got lost when the ECI FAQs were moved to the security FAQs section. I've added it to the As an aside, I liked it better when the ECI FAQs where under the ECI section, compared to where they are now (the security FAQ section). That's because the FAQs were closer to the most relevant content and could be more easily spotted from the TOC. |
Yes true. I'll create a follow-up PR after the release to move it. |
…19900) * Add note that docker build are not always protected by ECI. Signed-off-by: Cesar Talledo <cesar.talledo@docker.com> * Add ECI limitations to TOC. Signed-off-by: Cesar Talledo <cesar.talledo@docker.com> --------- Signed-off-by: Cesar Talledo <cesar.talledo@docker.com>
Description
** NOTE: Wait until the Docker Desktop 4.30 release to publish this change. **
Adds a note in the Enhanced Container Isolation (ECI) limitations section regarding docker build protections.
Reviews