Skip to content

Conversation

ctalledo
Copy link
Contributor

@ctalledo ctalledo commented Apr 26, 2024

Description

** NOTE: Wait until the Docker Desktop 4.30 release to publish this change. **

Adds a note in the Enhanced Container Isolation (ECI) limitations section regarding docker build protections.

Reviews

  • Technical review
  • Editorial review
  • Product review

@ctalledo ctalledo requested a review from aevesdocker as a code owner April 26, 2024 17:55
@github-actions github-actions bot added the area/desktop Issue affects a desktop edition of Docker. E.g docker for mac label Apr 26, 2024
Copy link

netlify bot commented Apr 26, 2024

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 5a07c73
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/662fd6070c5e08000865a380
😎 Deploy Preview https://deploy-preview-19900--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ctalledo ctalledo changed the title Add note that docker build are not always protected by ECI. Add note that docker builds are not always protected by ECI. Apr 26, 2024
Signed-off-by: Cesar Talledo <cesar.talledo@docker.com>
@ctalledo ctalledo force-pushed the eci-docker-builds branch from 2fadfbd to 665f4e8 Compare April 26, 2024 18:05
@aevesdocker aevesdocker added this to the 4.30 milestone Apr 29, 2024
Copy link
Contributor

@aevesdocker aevesdocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ctalledo, looks fine to me.
I noticed that limitations.md is no longer visible in the table of content for some reason 🤔 . Would you mind adding it to the toc.yaml file?

Signed-off-by: Cesar Talledo <cesar.talledo@docker.com>
@ctalledo
Copy link
Contributor Author

Thanks @ctalledo, looks fine to me. I noticed that limitations.md is no longer visible in the table of content for some reason 🤔 . Would you mind adding it to the toc.yaml file?

Thanks Allie (@aevesdocker); yes I noticed that too, I think it used to be tab within the ECI FAQs doc, but got lost when the ECI FAQs were moved to the security FAQs section.

I've added it to the toc.yaml file now.

As an aside, I liked it better when the ECI FAQs where under the ECI section, compared to where they are now (the security FAQ section). That's because the FAQs were closer to the most relevant content and could be more easily spotted from the TOC.

@aevesdocker
Copy link
Contributor

the FAQs were closer to the most relevant content and could be more easily spotted from the TOC.

Yes true. I'll create a follow-up PR after the release to move it.

@aevesdocker aevesdocker merged commit bf9e3bf into docker:main May 6, 2024
@ctalledo ctalledo deleted the eci-docker-builds branch May 6, 2024 16:12
elegantcoder pushed a commit to elegantcoder/docs that referenced this pull request Aug 28, 2024
…19900)

* Add note that docker build are not always protected by ECI.

Signed-off-by: Cesar Talledo <cesar.talledo@docker.com>

* Add ECI limitations to TOC.

Signed-off-by: Cesar Talledo <cesar.talledo@docker.com>

---------

Signed-off-by: Cesar Talledo <cesar.talledo@docker.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/desktop Issue affects a desktop edition of Docker. E.g docker for mac area/security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants