Skip to content

Adds documentation about the --ignore-override option #2019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 2, 2017

Conversation

dennisgove
Copy link

For PR docker/compose#4543

When option --ignore-override is provided the docker-compose.override.yml
file, if it exists, will not be considered for any command. This option
has no effect when the -f option is used as that explicitly lists the
set of files to be considered.

Signed-off-by: Dennis Gove dpgove@gmail.com

Proposed changes

Unreleased project version (optional)

Related issues (optional)

For PR docker/compose#4543

When option `--ignore-override` is provided the `docker-compose.override.yml`
file, if it exists, will not be considered for any command. This option
has no effect when the `-f` option is used as that explicitly lists the
set of files to be considered.

Signed-off-by: Dennis Gove <dpgove@gmail.com>
Copy link

@mdlinville mdlinville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @londoncalling should take a look.

@mdlinville mdlinville requested a review from londoncalling March 1, 2017 22:44
Copy link
Contributor

@londoncalling londoncalling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dennisgove
Copy link
Author

Thanks! I just want to be totally upfront here, the PR this documentation change is for has not yet been accepted - docker/compose#4543.

@mdlinville
Copy link

Ugh. OK, keep me posted. We can revert the commit if necessary.

@dennisgove
Copy link
Author

So far there haven't been any additional comments from accepters in docker/compose#4543

@mdlinville
Copy link

@shin- any update on this?

@shin-
Copy link
Contributor

shin- commented Mar 8, 2017

As I pointed out in docker/compose#4543 (comment), this feature already exists. I'd recommend reverting this as it's unlikely this will make it into the project.

@dennisgove
Copy link
Author

Thank you @shin-.

@mstanleyjones, please revert this commit. I'm very sorry for the inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants