Skip to content

Conversation

ctalledo
Copy link
Contributor

@ctalledo ctalledo commented Nov 7, 2024

NOTE: Do not merge until Docker Desktop v4.36 is released.

Description

Documents a couple of improvements for DD 4.36 in the ECI Docker Socket mount permissions feature.

Related issues or tickets

https://docker.atlassian.net/browse/POS-2740

Reviews

  • Technical review
  • Editorial review
  • Product review

Copy link

netlify bot commented Nov 7, 2024

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit b8b29d7
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/6733c4e2e5b9190008654f8f
😎 Deploy Preview https://deploy-preview-21357--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aevesdocker aevesdocker added this to the 4.36 milestone Nov 7, 2024
Copy link
Contributor

@aevesdocker aevesdocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ctalledo, just some nits

Signed-off-by: Cesar Talledo <cesar.talledo@docker.com>
@ctalledo ctalledo force-pushed the eci-docker-socket-mount-perm-improvement branch from d62a834 to b8b29d7 Compare November 12, 2024 21:13
@ctalledo
Copy link
Contributor Author

Thanks Allie (@aevesdocker) for the review, I applied all your suggestions.

Copy link
Contributor

@aevesdocker aevesdocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@aevesdocker aevesdocker merged commit d0e5d1a into docker:main Nov 18, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants