-
Notifications
You must be signed in to change notification settings - Fork 8k
chore: summary bar cleanup #21887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: summary bar cleanup #21887
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I'm actually not sure about replacing the |
I'd much rather have just one way of showing this data. I thought we ended up with a shortcode for the summary bar because it allows us the flexibility to put it on a section-level? If we only ever want to render this component at the top of a page, then it probably shouldn't even be a shortcode. Pretty sure we discussed this when reviewing the original PR. |
I would also prefer to have one way of showing this data. I think if we introduce too many types of callouts or visual elements that represent a bunch of different things, we get into a territory that becomes difficult to maintain and be consistent with. Also as a user, the more consistent we are, the better I recognize and understand these elements over time. For these visual elements, I would prefer keeping things limited to summary bars and callouts, and implementing them at the section level as needed. Also, these are implemented at the section level in other docs from the original PR. @aevesdocker I can adjust the text shown in the |
@aevesdocker @dvdksn I am able to add the release notes to the summary bar |
Looks like I'm outnumbered! Adding the release notes link LGTM, thanks @sarahsanders-docker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can also remove these, they were used by the introduced.html shortcode
Lines 39 to 54 in ee59422
## component names buildx: other: Buildx buildkit: other: BuildKit engine: other: Docker Engine api: other: Engine API desktop: other: Docker Desktop compose: other: Docker Compose scout: other: Docker Scout Lines 130 to 139 in ee59422
# Minimum version thresholds (used together with the "introduced" shortcode # See layouts/shortcodes/introduced.html min_version_thresholds: buildx: "0.10.0" buildkit: "0.11.0" engine: "24.0.0" api: "1.41" desktop: "4.20.0" compose: "2.14.0" scout: "1.0.0"
Description
introduced
partial, this is now replaced by the summary barrequires
valueintroduced
partial to use summary bar, updated YAML file w/ feature name and infoRelated issues or tickets
ENGDOCS-2392
Reviews