Skip to content

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented Apr 9, 2025

@github-actions github-actions bot added the area/build Relates to Dockerfiles or docker build command label Apr 9, 2025
Copy link

netlify bot commented Apr 9, 2025

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 44b939d
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/67f687e5e157de0008564dfa
😎 Deploy Preview https://deploy-preview-22395--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@crazy-max crazy-max force-pushed the gha-cache-service-v2 branch 2 times, most recently from 27dce26 to 2ee3f30 Compare April 9, 2025 10:01
@crazy-max crazy-max marked this pull request as ready for review April 9, 2025 10:05
@crazy-max crazy-max requested a review from aevesdocker as a code owner April 9, 2025 10:05
@crazy-max crazy-max force-pushed the gha-cache-service-v2 branch from 2ee3f30 to f98315f Compare April 9, 2025 10:58
Copy link
Contributor

@aevesdocker aevesdocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Real picky nits, rest LGTM @crazy-max

Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
@crazy-max crazy-max force-pushed the gha-cache-service-v2 branch from f98315f to 44b939d Compare April 9, 2025 14:44
Copy link
Member Author

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review @aevesdocker, should be good now.

@crazy-max crazy-max requested a review from aevesdocker April 9, 2025 14:45
Copy link
Contributor

@aevesdocker aevesdocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @crazy-max

@aevesdocker aevesdocker merged commit 2f787e1 into docker:main Apr 9, 2025
14 checks passed
@crazy-max crazy-max deleted the gha-cache-service-v2 branch April 9, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/build Relates to Dockerfiles or docker build command

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants