Skip to content

Conversation

craig-osterhout
Copy link
Contributor

@craig-osterhout craig-osterhout commented Sep 30, 2025

Description

Current issues:

  • There are several package.json files, so it's ambiguous.
  • There is already a Dockerfile, so it must be deleted if asking the user to create one. Also, the existing Dockerfile has a different image version than the one the user is asked to create.

Fixes:

  • Added step to explore the existing Dockerfile to have a smoother transition into deleting it.
  • Added step to delete the Dockerfile.
  • Updated step to specify the exact folder where to create the new Dockerfile.

https://deploy-preview-23478--docsdocker.netlify.app/get-started/docker-concepts/building-images/writing-a-dockerfile/#creating-the-dockerfile

Related issues or tickets

https://docker.slack.com/archives/C04BMTUC41E/p1759261212446019

Reviews

  • Editorial review

Signed-off-by: Craig <craig.osterhout@docker.com>
Signed-off-by: Craig <craig.osterhout@docker.com>
@craig-osterhout craig-osterhout requested a review from a team September 30, 2025 21:48
@craig-osterhout craig-osterhout added area/get-started Relates to get started and onboarding docs status/review labels Sep 30, 2025
Copy link

netlify bot commented Sep 30, 2025

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit e3a5972
🔍 Latest deploy log https://app.netlify.com/projects/docsdocker/deploys/68dc504a47762b0008ecc99c
😎 Deploy Preview https://deploy-preview-23478--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@craig-osterhout craig-osterhout merged commit 88ef79f into docker:main Oct 1, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/get-started Relates to get started and onboarding docs status/review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants