Update Task2, Step1 in 'set-up-dev-env.md' #2863
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally the step mentioned Mac in general but the step is actually just for Docker Toolbox users.
mdlinville
suggested changes
Apr 18, 2017
opensource/project/set-up-dev-env.md
Outdated
| 1. Open a terminal. | ||
|
|
||
| For Mac users, use `docker-machine status your_vm_name` to make sure your VM is running. You | ||
| For <a href="/toolbox/overview/" target="_blank">Docker Toolbox</a> users, use `docker-machine status your_vm_name` to make sure your VM is running. You |
There was a problem hiding this comment.
Almost there, but please use Markdown-style links. Like [link-text](https://url)
There was a problem hiding this comment.
Sure thing. I started to do that but noticed the next link in the page was using the HTML-style link so I just followed that.
If you like, I can fix that other link as well. I assume you'd want that as a separate PR, but should I open an issue to make that update as well?
Link was using HTML-style link and has now been updated to use Markdown-style.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally the step mentioned Mac in general but the step is actually just for Docker Toolbox users. So I just updated to reference Docker Toolbox specifically with a link to the Docker Toolbox doc page.
This closes #974.