-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add d4mac client side FAQ #3671
Conversation
@londoncalling, it works on windows too |
@ebriney @YangLi @mstanleyjones @friism Please review this carefully, via the Netlify links provided.
|
the registry will produce error messages on the command line, as well as on the | ||
registry. | ||
|
||
### Directory structures for certificates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if it'd be useful to link to https://docs.docker.com/engine/security/certificates/? That document has more details about the directory structure for /etc/docker/certs.d
docker-for-mac/index.md
Outdated
`~/.docker/certs.d/<MyRegistry>:<Port>/client.key`. | ||
|
||
When the Docker for Mac application starts up, it copies certificates from your | ||
Mac folders to `~/.docker/certs.d` in the database. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this say something like "...it copies the ~/.docker/certs.d
folder on your Mac to the com.docker.driver.amd64-linux/etc/docker/certs.d
directory in the database." instead? Also, I'm not sure if mentioning the database is helpful for folks who weren't doing git
commands before.
Maybe "...it copies the ~/.docker/certs.d
folder on your Mac into the /etc/docker/certs.d
directory in the xhyve VM." ?
docker-for-mac/index.md
Outdated
|
||
``` | ||
/Users/<user>/.docker/certs.d/ | ||
└── 192.168.203.139:5858 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since ~/docker/certs.d/<MyRegistry>:<Port>/client.key
etc. was mentioned above, for consistency do we want to change the folder name from 192.168.203.139:5858
to <MyRegistry>:<Port>
?
Alternately, since https://docs.docker.com/engine/security/certificates/#creating-the-client-certificates uses "localhost:5000" as the hostname with port, maybe we should use that instead? Similar with the example below.
docker-for-mac/index.md
Outdated
@@ -331,14 +334,96 @@ This option removes/resets all Docker data _without_ a reset to factory defaults | |||
|
|||
![Uninstall or reset Docker Edge features](images/settings-uninstall-edge.png) | |||
|
|||
## Adding security certificates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps "Adding TLS certificates" instead of "security certificates"?
@cyli Thanks for your review, I've incorporated all of your comments. Have a look if you get a chance. I'm still a little worried about the Windows side of it, but if I don't get any other comments, I'll merge this and figure users will send questions or comments once it's published. |
docker-for-windows/faqs.md
Outdated
When the Docker for Windows application starts up, it copies certificates from | ||
your Windows folders to `~/.docker/certs.d` in the database. | ||
|
||
> * You need to restart Docker for Mac after making any changes to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Docker for Mac" -> "Docker for Windows"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, thanks, @JimGalasyn
docker-for-mac/index.md
Outdated
@@ -331,14 +334,112 @@ This option removes/resets all Docker data _without_ a reset to factory defaults | |||
|
|||
![Uninstall or reset Docker Edge features](images/settings-uninstall-edge.png) | |||
|
|||
## Adding TLS certificates | |||
|
|||
You can add server side (registry) and client side certificates to verify the identity of these entities. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies, one more nitpick: it's not clear what "these entities" refer to. Maybe this sentence can be:
"You can add CA certificates (used to verify registry server certificates) and client certificates (used to authenticate to registries) to your docker daemon."
Or something like that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cyli makes sense, I'll change that now. I made some more updates, I think it's looking pretty good.
Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>
Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>
Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>
Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>
Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>
Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>
Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>
Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>
Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>
Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>
Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>
LGTM |
@ebriney You confirmed this works for Windows as well? I think I am doing exactly what the FAQ describes but can't make it work, and am left scratching my head. Do you have any clues about what might be wrong? Thanks (I also posted my question to the forum https://forums.docker.com/t/using-client-certificates/41364) |
What's changed
-Added an FAQ re: client side certificates on Docker for Mac
Related
docker/for-mac#1320 (comment)
Netlify preview direct links
Docker for Mac FAQ on client-side certs
Update to Docker for Mac FAQ on server side CA certificates per @YanLi
Docker for Windows FAQ on client-side certs
Reviewers
@matthewbarr @ebriney @friism @YangLi @mstanleyjones @JimGalasyn
Signed-off-by: Victoria Bialas victoria.bialas@docker.com