Skip to content

Conversation

rishabh9
Copy link
Contributor

@rishabh9 rishabh9 commented Nov 17, 2017

Suggestion to fix warnings when docker is configured to be used by non-root user.

Proposed changes

On following the instructions under Manage Docker as a non-root user subheading, we face a warning every time we run an image. To fix the warning, the documentation should suggest correcting the permissions to the ~/.docker folder. Thus this PR contains a note to fix the warning.

Unreleased project version (optional)

Related issues (optional)

Fixes #5326

Suggestion to fix warnings when docker is configured to be used by non-root user.
@mdlinville mdlinville changed the title Fix linux-postinstall.md for issue #5326 Fix linux-postinstall.md Nov 17, 2017
Copy link

@mdlinville mdlinville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with copyedit and expanded explanation of the problem

@mdlinville mdlinville requested a review from thaJeztah November 17, 2017 20:15
@mdlinville
Copy link

Thanks! I expanded upon your explanation a bit, fixed some Markdown problems (you need newlines between text and codeblocks for the Markdown parser we use), and tweaked the title of the PR not to include an issue ID.

@mdlinville mdlinville merged commit 8504d0a into docker:master Nov 17, 2017
@rishabh9 rishabh9 deleted the patch-1 branch November 18, 2017 05:45
@rishabh9
Copy link
Contributor Author

Thanks! Will keep your comments in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add note regarding config.json permission warning post docker install
2 participants