This repository has been archived by the owner on Jun 16, 2021. It is now read-only.
Add support for --no-build #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdemeester
force-pushed
the
no-build-support
branch
2 times, most recently
from
b451986
to
89207c9
Compare
vdemeester
force-pushed
the
no-build-support
branch
from
89207c9
to
0bdaad7
Compare
|
I just have a small nit regarding the |
|
@runcom just |
|
@vdemeester right cool |
vdemeester
force-pushed
the
no-build-support
branch
3 times, most recently
from
dd8f5ae
to
ac946a9
Compare
This adds support for the --no-build flag for create and up commands. Also contains a small refactoring on how libcompose decides to build or not the image (it aligns with how docker-compose does). Signed-off-by: Vincent Demeester <vincent@sbr.pm>
vdemeester
force-pushed
the
no-build-support
branch
from
ac946a9
to
89a14b9
Compare
|
/ping @ibuildthecloud @dnephin |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the
--no-buildflag forcreateandupcommands.Also contains a small refactoring on how libcompose decides to build or
not the image (it aligns with how docker-compose does). 🐠
FIXMEs🐸
Signed-off-by: Vincent Demeester vincent@sbr.pm