This repository has been archived by the owner on Sep 26, 2021. It is now read-only.
exoscale: support for CoreOS #3214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM -- thanks @vincentbernat ! Can you squash the changes into one commit please @vincentbernat ? |
|
Good job, thank you! |
The egoscale binding for exoscale was limiting the images that could be
selected by a user to Ubuntu one only. Enable the use of arbitrary
images. For example, the following images are now available:
- centos-6.6
- centos-7.1
- coreos-stable-835
- debian-7
- debian-8
- ubuntu-12.04
- ubuntu-14.04
- ubuntu-15.10
The default user for non-Ubuntu images are not "ubuntu". Let the user
choose the appropriate user ("core" for CoreOS and "debian" for Debian).
CoreOS user are likely to want the ability to provide custom user data
as it enables the configuration of the etcd cluster. We add an option to
provide custom user data file. Moreover, we remove some of the default
options as they are not supported in CoreOS and are useless on
Debian/Ubuntu:
- Resizing of rootfs is already done on all images by default.
- Docker Machine will set the hostname as part of the provisioning.
Signed-off-by: Vincent Bernat <Vincent.Bernat@exoscale.ch>
vincentbernat
force-pushed
the
feature/update-egoscale
branch
from
97b2359
to
05aea83
Compare
|
Squashed. |
|
Thanks Vincent! LGTM |
nathanleclaire
added a commit
that referenced
this pull request
Mar 22, 2016
exoscale: support for CoreOS
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!
Here is a small update for the exoscale driver to properly support CoreOS. The first commit enables the use of the CoreOS image by updating the egoscale binding. The second one allows one to specify an chosen SSH user (for CoreOS, "core"). The third one enables the user to provide its own user-data. It was quite useless when provisioning Ubuntu OS, but some users are asking it for CoreOS (notably to configure etcd).