Skip to content
This repository has been archived by the owner on Sep 26, 2021. It is now read-only.

Amazon EC2 - Adding option to inject EC2 user data at launch #1637

Closed
wants to merge 1 commit into from

Conversation

nrdlngr
Copy link

@nrdlngr nrdlngr commented Aug 3, 2015

Signed-off-by: Eric Nordlund nrdlngr@gmail.com

Signed-off-by: Eric Nordlund <nrdlngr@gmail.com>
@ehazlett
Copy link
Contributor

ehazlett commented Aug 7, 2015

@nrdlngr thanks for the contribution however we are really trying to have an opinionated control over the provisioning. since not all providers support this we don't want to have different experiences across the drivers. thanks!

@ehazlett ehazlett closed this Aug 7, 2015
@nathanleclaire
Copy link
Contributor

Thanks for your contribution! I agree with @ehazlett on closing this -- To elaborate a little further on my reasoning:

  1. The EC2 driver already has a lot stuff in it and we'd still really like to do a rewrite using the Stripe API bindings (now official) instead of our homebrew solution. It moved really quickly in the early days and we're still struggling to clean it up.
  2. Before we go throwing things like custom user data into the mix, we need to get comfortable with the matrix we already have (OS x Provider) and provide the most uniform experience possible. Before we allow flexibility in terms of provisioning, we have to decide what we are and are not willing to accept and define a real provisioning model, e.g. Do we support cloud-init only? Do we allow users to run bash scripts at various points in provisioning? Do we bootstrap Compose automatically? There's a lot to consider.

It's not "no forever", but we need a definition of behavior which is relatively consistent across drivers before letting such a feature in.

@bjaglin
Copy link

bjaglin commented Apr 30, 2016

Any chance this decision could be revisited? #2141 & #3214 were merged since so this would actually improve consistency across cloud drivers.

@nathanleclaire
Copy link
Contributor

I'd certainly review a pull request. It will need to be different than this code probably since the EC2 driver has been re-written to use the official Go bindings for AWS.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants