Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github CI, fix cmake test definition #152

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

thelema
Copy link

@thelema thelema commented Mar 26, 2022

This pull request adds github CI support so master and branches can be regressed automatically against existing tests.

@thelema
Copy link
Author

thelema commented Mar 26, 2022

Let me know if you want the history on this cleaned up. I'm expecting this to be squash-merged into your repo.

CMakeLists.txt Outdated Show resolved Hide resolved
@thelema
Copy link
Author

thelema commented Apr 25, 2022

@jaredgrubb any chance of getting this merged?

@jaredgrubb
Copy link
Member

I haven't used GitHub CI before .. how will this appear once merged?

@mibli
Copy link

mibli commented May 16, 2022

@jaredgrubb You get a checkmark next to a verified commit, You can inspect the build and logs for set amount of time theyre available, in the build it's pretty standard, You get step rundown with logs and success/failures. Every Pull Request will have CI rundown for each new update. Here's a short introduction video.

@jaredgrubb
Copy link
Member

So once we merge this, it'll just kick in? or is there further setup that I'll need to do?

Thanks for the idea on this!

@thelema
Copy link
Author

thelema commented May 22, 2022 via email

@NickCrews
Copy link

This looks like a great idea and a good implementation to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants