Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the src directory from packages.json's files #1343

Open
anikethsaha opened this issue Aug 19, 2020 · 3 comments · Fixed by #1344
Open

Remove the src directory from packages.json's files #1343

anikethsaha opened this issue Aug 19, 2020 · 3 comments · Fixed by #1344
Labels
bug confirmed as a bug priority : high

Comments

@anikethsaha
Copy link
Member

anikethsaha commented Aug 19, 2020

Remove this line https://github.com/docsifyjs/docsify/blob/develop/package.json#L20 , till now we are publishing this directory as well and we should not have that.

@trusktr
Copy link
Member

trusktr commented Aug 21, 2020

There's no good reason to make these sorts of breaking changes. It is useful for some people to rely on source files for build systems, and if someone already is, then this breaks their setup.

We should instead try writing tests. We don't need to wait for playwright PR to be finished in order to begin doing that.

@trusktr trusktr reopened this Aug 21, 2020
@sy-records
Copy link
Member

I think the build system should use github instead of npm

@anikethsaha
Copy link
Member Author

I think it was kept as a mistake may cause even if we use this from cdn, it will break as styles are written in .styl and ja as modules.
And it is not mentioned in anywhere to use any files from src/*. So I think even if it is breaking, it might not be an issue with us.
Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug confirmed as a bug priority : high
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants