New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Edit document"goes to 404 error page #562

Closed
SidVal opened this Issue Jul 2, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@SidVal
Contributor

SidVal commented Jul 2, 2018

I think there is a 馃悰 (bug) with "edit document":
https://github.com/docsifyjs/docsify/blob/master/docs/index.html#L65

If we are on default language, no 馃悰 but, in other language, we'll have 404 error.
Check it out:

  1. 馃嚭馃嚫 : https://docsify.js.org/#/quickstart click on: "Edit document". Result: OK !
  2. 馃嚛馃嚜 : https://docsify.js.org/#/de-de/quickstart click on: "Edit document". Result: 404 error page! 馃憥
  3. 馃嚜馃嚫 : https://docsify.js.org/#/es/quickstart click on: "Edit document". Result: 404 error page! 馃憥

@QingWei-Li QingWei-Li closed this in 78b3a6d Jul 5, 2018

@SidVal

This comment has been minimized.

Contributor

SidVal commented Jul 6, 2018

@QingWei-Li now if you click on "Edit document" here: https://docsify.js.org/#/quickstart you have 404 error. 馃槩

But, you fixed the "edit document" in other languages 馃憤

QingWei-Li added a commit that referenced this issue Jul 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment