Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1032 #1043

Closed
wants to merge 1 commit into from
Closed

fix #1032 #1043

wants to merge 1 commit into from

Conversation

csu-feizao
Copy link

Summary
fix #1032

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:


  • DO NOT include files inside lib directory.

@anikethsaha
Copy link
Member

Thanks for the PR. Please add test if possible ! I will review it soon.
Also make sure it doesnt break for special cases like _, -, >, . etc

@anikethsaha anikethsaha self-assigned this Mar 3, 2020
@anikethsaha anikethsaha closed this Mar 4, 2020
@anikethsaha anikethsaha reopened this Mar 4, 2020
@anikethsaha anikethsaha self-requested a review March 9, 2020 07:53
Copy link
Member

@anikethsaha anikethsaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this locally, the bug mentioned in #1032 still persist (the expand issue and highlighting as well). Try re-check and test it against this demo

@stale
Copy link

stale bot commented May 8, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label May 8, 2020
@anikethsaha anikethsaha removed their assignment May 8, 2020
@stale stale bot removed the wontfix label May 8, 2020
@stale
Copy link

stale bot commented Jul 7, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jul 7, 2020
@sy-records
Copy link
Member

@csu-feizao Can you fix the problem?

@stale stale bot removed the wontfix label Jul 7, 2020
@enzy
Copy link
Contributor

enzy commented Dec 17, 2020

This is just 2 line change (see diff). Can we create a fresh PR and merge that please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sidebar active class and expand don't work as expect when use "space" in markdown filename
4 participants