Added 'defaultFallbackLanguage' config parameter. #916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Added 'defaultFallbackLanguage' parameter to avoid the need of having the default language in root folder.
digforit
changed the title
semoal
approved these changes
Sep 9, 2019
| } | ||
| const newPath = path.replace(new RegExp(`^/${local}`), '') | ||
|
|
||
| var defaultLanguage = ''; |
There was a problem hiding this comment.
Suggested change
| var defaultLanguage = ''; | |
| let defaultLanguage = ''; |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
anikethsaha
requested changes
Feb 4, 2020
| } | ||
| const newPath = path.replace(new RegExp(`^/${local}`), '') | ||
|
|
||
| var defaultLanguage = ''; |
There was a problem hiding this comment.
Suggested change
| var defaultLanguage = ''; | |
| var defaultLanguage = defaultFallbackLanguage ? defaultFallbackLanguage : ''; |
and remove the if stmt.
There was a problem hiding this comment.
In this case you could convert this to a const and not a let as mentioned
|
|
||
| proto._fetchFallbackPage = function (path, qs, cb = noop) { | ||
| const {requestHeaders, fallbackLanguages, loadSidebar} = this.config | ||
| const {requestHeaders, defaultFallbackLanguage, fallbackLanguages, loadSidebar} = this.config |
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way we can have exactly formatted folders for each language including the default one without having to mix the default language with root files.
Summary
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx], where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information:
libdirectory.