feat: add rules for trailing commas in function declarations#268
Merged
ostrolucky merged 1 commit intodoctrine:10.0.xfrom Jun 21, 2022
Merged
feat: add rules for trailing commas in function declarations#268ostrolucky merged 1 commit intodoctrine:10.0.xfrom
ostrolucky merged 1 commit intodoctrine:10.0.xfrom
Conversation
27054ef to
f3cd3a4
Compare
Ocramius
reviewed
Jun 19, 2022
greg0ire
reviewed
Jun 19, 2022
ostrolucky
approved these changes
Jun 20, 2022
derrabus
approved these changes
Jun 20, 2022
Member
|
Hopefully trailing commas in function calls are incoming too? :) |
Ocramius
approved these changes
Jun 20, 2022
malarzm
approved these changes
Jun 20, 2022
SenseException
approved these changes
Jun 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes trailing commas on single line declarations
Requires comma in multiline declarations
function foo( $bar, $baz, )so extending args produces nice diff (one line modified)
function foo( $bar, $baz, + $bam, )