ci: do not throw away exit codes#275
Merged
greg0ire merged 1 commit intodoctrine:10.0.xfrom Jun 29, 2022
Merged
Conversation
simPod
force-pushed
the
fix-make
branch
11 times, most recently
from
8849686 to
35d5c22
Compare
greg0ire
reviewed
Jun 27, 2022
greg0ire
reviewed
Jun 27, 2022
greg0ire
approved these changes
Jun 28, 2022
SenseException
approved these changes
Jun 28, 2022
Ocramius
approved these changes
Jun 29, 2022
Member
|
Thanks @simPod ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I could have noticed this sooner but we were throwing away test failures on unpatched versions - exit code was being overridden.
I tried to fix it in Make first but then decided to go with bash because of its flexibility (e.g. can define variables and traps).