Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 10.0.x into 10.1.x #302

Merged
merged 4 commits into from
Dec 10, 2022
Merged

Merge 10.0.x into 10.1.x #302

merged 4 commits into from
Dec 10, 2022

Conversation

greg0ire
Copy link
Member

No description provided.

GaryJones and others added 4 commits September 29, 2022 15:46
As per https://getcomposer.org/doc/04-schema.md#keywords by including
"dev" as a keyword in the `composer.json` file, Composer 2.4.0-RC1 and
later will prompt users if the package is installed with `composer
require` instead of `composer require --dev`. See
composer/composer#10960 for more info.
Upstream package has fixed a false positive with self::CONSTANT

Here is how the false positive looked like

>   9 | ERROR | [ ] Invalid inline documentation comment format "@var int", expected "@var type $variable Optional description".
>     |       |     (SlevomatCodingStandard.Commenting.InlineDocCommentDeclaration.InvalidFormat)

It was about these lines:

> /** @var int */
> const FOO = 123;
Add "dev" Composer keyword
@greg0ire greg0ire mentioned this pull request Dec 10, 2022
@greg0ire greg0ire requested a review from a team December 10, 2022 10:50
@ostrolucky ostrolucky merged commit 21c24ed into 10.1.x Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants