Skip to content

Adjust expectations #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2022
Merged

Adjust expectations #300

merged 1 commit into from
Oct 27, 2022
+14 −14

Conversation

@greg0ire
Copy link
Member

@greg0ire greg0ire commented Oct 27, 2022 •
edited
Loading

Upstream package has fixed a false positive with self::CONSTANT

Here is how the false positive looked like

   9 | ERROR | [ ] Invalid inline documentation comment format "@var int", expected "@var type $variable Optional description".
     |       |     (SlevomatCodingStandard.Commenting.InlineDocCommentDeclaration.InvalidFormat)

It was about these lines:

/** @var int */
const FOO = 123;

@greg0ire greg0ire force-pushed the adjust-expectations branch from 10d3a74 to 8eb81f4 Compare October 27, 2022 18:40
@greg0ire
Adjust expectations
4e45530 
Upstream package has fixed a false positive with self::CONSTANT

Here is how the false positive looked like

>   9 | ERROR | [ ] Invalid inline documentation comment format "@var int", expected "@var type $variable Optional description".
>     |       |     (SlevomatCodingStandard.Commenting.InlineDocCommentDeclaration.InvalidFormat)

It was about these lines:

> /** @var int */
> const FOO = 123;
@greg0ire greg0ire force-pushed the adjust-expectations branch from 8eb81f4 to 4e45530 Compare October 27, 2022 18:44
@greg0ire greg0ire marked this pull request as ready for review October 27, 2022 20:17
@greg0ire greg0ire requested a review from a team October 27, 2022 20:17
@ostrolucky ostrolucky merged commit 91106f7 into doctrine:10.0.x Oct 27, 2022
@greg0ire greg0ire deleted the adjust-expectations branch October 27, 2022 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ostrolucky ostrolucky ostrolucky approved these changes

@derrabus derrabus derrabus approved these changes

+1 more reviewer

@Ocramius Ocramius Ocramius approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@greg0ire @Ocramius @ostrolucky @derrabus