Remove PHPCS workflow #347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simPod
suggested changes
Sep 18, 2025
greg0ire
force-pushed
the
remove-phpcs-workflow
branch
from
318e048 to
dea7424
Compare
greg0ire
changed the title
It should not have been introduced, as there were no PHP files to check inside lib.
greg0ire
force-pushed
the
remove-phpcs-workflow
branch
from
dea7424 to
0c37006
Compare
|
I've seen the smoke test and wasn't convinced it was necessary. Good point about removing the whole job though, I definitely missed that! |
We only every call phpcbf with an argument, so this tag never gets used. It was useful before 69af948, when there were sniffs inside lib.
greg0ire
force-pushed
the
remove-phpcs-workflow
branch
from
0c37006 to
b03c30b
Compare
simPod
approved these changes
Sep 18, 2025
pieterocp
approved these changes
Sep 18, 2025
ostrolucky
approved these changes
Sep 18, 2025
SenseException
approved these changes
Sep 18, 2025
derrabus
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It shouldn't have been introduced in the first place, as there were no files to check inside
libanymore.