Skip to content

Commit

Permalink
Merge branch '2.12.x' into 3.0.x
Browse files Browse the repository at this point in the history
  • Loading branch information
morozov committed Nov 1, 2020
2 parents 3becaec + c2b989e commit d67f89d
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 67 deletions.
2 changes: 1 addition & 1 deletion UPGRADE.md
Original file line number Diff line number Diff line change
Expand Up @@ -456,7 +456,7 @@ The following PDO-related classes outside of the PDO namespace have been depreca
3. `prefersSequences()`.
4. `supportsForeignKeyOnUpdate()`.

##`ServerInfoAwareConnection::requiresQueryForServerVersion()` is deprecated.
## `ServerInfoAwareConnection::requiresQueryForServerVersion()` is deprecated.

The `ServerInfoAwareConnection::requiresQueryForServerVersion()` method has been deprecated as an implementation detail which is the same for almost all supported drivers.

Expand Down
76 changes: 11 additions & 65 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 8 additions & 1 deletion tests/Functional/TransactionTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

use Doctrine\DBAL\Platforms\MySQLPlatform;
use Doctrine\DBAL\Tests\FunctionalTestCase;
use PDOException;

use function sleep;

Expand Down Expand Up @@ -35,6 +36,12 @@ public function testCommitFalse(): void

sleep(2); // during the sleep mysql will close the connection

self::assertFalse(@$this->connection->commit()); // we will ignore `MySQL server has gone away` warnings
try {
self::assertFalse(@$this->connection->commit()); // we will ignore `MySQL server has gone away` warnings
} catch (PDOException $e) {
/* For PDO, we are using ERRMODE EXCEPTION, so this catch should be
* necessary as the equivalent of the error control operator above.
* This seems to be the case only since PHP 8 */
}
}
}

0 comments on commit d67f89d

Please sign in to comment.