QueryBuilder uses 1-based positional parameter keys

[morozov]

Bug Report

Q	A
BC Break	no
Version	2.12.1

Summary

According to the documentation,

dbal/docs/en/reference/query-builder.rst

Lines 47 to 48 in 84328cd

	The numerical parameters in the QueryBuilder API start with the needle
	``0``, not with ``1`` as in the PDO API.

The usage of non-zero-based keys has been explicitly deprecated in #4411. The issue was discovered during the work on #4397 which enforces this deprecation.

Current behaviour

When using QueryBuilder::createPositionalParameter(), the keys are created starting from 1.

How to reproduce

$qb = $conn->createQueryBuilder();
$qb->select($qb->createPositionalParameter('FOO'));

var_dump($qb->getParameters());
// array(1) {
//   [1] =>
//   string(3) "FOO"
// }

Expected behaviour

// array(1) {
//   [0] =>
//   string(3) "FOO"
// }

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.