Deprecate inappropriate usage of prepared statement parameters #4411
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The current SQL parser implementation allows certain usages that are rather a side effects of the existing implementation than something that the implementation was purposefully designed for.
dbal/lib/Doctrine/DBAL/SQLParserUtils.php
Lines 152 to 153 in 99f9c7e
dbal/lib/Doctrine/DBAL/SQLParserUtils.php
Lines 177 to 178 in 99f9c7e
dbal/tests/Doctrine/Tests/DBAL/SQLParserUtilsTest.php
Lines 313 to 333 in 99f9c7e
dbal/docs/en/reference/data-retrieval-and-manipulation.rst
Line 95 in 99f9c7e
The behavior above should be deprecated in order to allow future rework of the parser w/o introducing breaking changes.