Type and name sql argument of query function #2918
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rey0bs
changed the title
rey0bs
force-pushed
the
query-variable-arguments
branch
from
b47cff0
to
cacfece
Compare
rey0bs
changed the title
rey0bs
force-pushed
the
query-variable-arguments
branch
from
c58e602
to
2002e52
Compare
Majkl578
reviewed
Dec 9, 2017
| * @return \Doctrine\DBAL\Driver\Statement | ||
| * | ||
| * @throws \Doctrine\DBAL\DBALException | ||
| */ | ||
| public function query() | ||
| public function query($sql, ...$args) |
There was a problem hiding this comment.
This change is a BC break and couldn't be considered for 2.x.
|
Obsolete as of #3803. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several functions use first argument of
Connection::queryfunction. This argument is named and typed as string in functions which use it, but is not documented inqueryfunction.For example, in
Doctrine\DBAL\Connection, the logger uses it instartQueryfunction.$sqlis named and typed inSQLLoggerinterface, but not inqueryfunction.This PR names this argument to increase visibility and avoid to use
func_get_argsand$args[0]for$sqlparameter.