Type and name sql argument of query function #2918
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several functions use first argument of
Connection::query
function. This argument is named and typed as string in functions which use it, but is not documented inquery
function.For example, in
Doctrine\DBAL\Connection
, the logger uses it instartQuery
function.$sql
is named and typed inSQLLogger
interface, but not inquery
function.This PR names this argument to increase visibility and avoid to use
func_get_args
and$args[0]
for$sql
parameter.