-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed build failure on SQL Server #3061
Conversation
Apparently, the @Majkl578 any idea what can be wrong with the configuration? Hm… interestingly, locally I see the same pattern of errors but a different error message:
|
The regression was introduced by 2b8c40d. Fixes doctrine#3060.
Use a wrapped PDO Statement instead of a custom class for `pdo_sqlsrv` since `PDOSqlsrv\Statement` doesn't extend `PDOStatement` anymore.
That fatal error on Travis is #3049. @carusogabriel was about to investigate, not sure how far he got. Imho SF PHPUnit bridge related. |
@Majkl578 Thanks for remember me, I have forgot to look at this. Gonna look ASAP to figure out what is going wrong 👨🏻💻 |
@Ocramius I've restarted the AppVeyor build, all green now. |
Aaaaaand 🚢 |
The regression was introduced by 2b8c40d.
Fixes #3060.