Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed build failure on SQL Server #3061

Merged
merged 2 commits into from
Mar 20, 2018
Merged

Conversation

morozov
Copy link
Member

@morozov morozov commented Mar 20, 2018

The regression was introduced by 2b8c40d.

Fixes #3060.

@morozov
Copy link
Member Author

morozov commented Mar 20, 2018

Apparently, the pdo_sqlsrv build is still failing with the same message as in #3049, however, the sqlsrv and pdo_sqlsrv configurations are the same.

@Majkl578 any idea what can be wrong with the configuration?

Hm… interestingly, locally I see the same pattern of errors but a different error message:

$  phpunit -c pdo_sqlsrv.phpunit.xml --stop-on-error 
PHPUnit 7.0.2 by Sebastian Bergmann and contributors.

.....................SSSSS.....................................SSS...........   77 / 3787 (  2%)
.SS..............S.......SS..S.SSS..........E

Time: 1.43 seconds, Memory: 34.00MB

There was 1 error:

1) Doctrine\Tests\DBAL\Driver\Mysqli\MysqliConnectionTest::testDoesNotRequireQueryForServerVersion
PDOException: SQLSTATE[HY000]: General error: user-supplied statement class must be derived from PDOStatement

/home/morozov/Projects/dbal/lib/Doctrine/DBAL/Driver/PDOSqlsrv/Connection.php:21
/home/morozov/Projects/dbal/lib/Doctrine/DBAL/Driver/PDOSqlsrv/Driver.php:23
/home/morozov/Projects/dbal/lib/Doctrine/DBAL/Connection.php:362
/home/morozov/Projects/dbal/lib/Doctrine/DBAL/Connection.php:424
/home/morozov/Projects/dbal/lib/Doctrine/DBAL/Connection.php:386
/home/morozov/Projects/dbal/lib/Doctrine/DBAL/Connection.php:330
/home/morozov/Projects/dbal/tests/Doctrine/Tests/TestUtil.php:87
/home/morozov/Projects/dbal/tests/Doctrine/Tests/TestUtil.php:53
/home/morozov/Projects/dbal/tests/Doctrine/Tests/TestUtil.php:44
/home/morozov/Projects/dbal/tests/Doctrine/Tests/DbalFunctionalTestCase.php:35
/home/morozov/Projects/dbal/tests/Doctrine/Tests/DBAL/Driver/Mysqli/MysqliConnectionTest.php:25

@morozov morozov changed the title Fixed build failure on SQL Server Fixed build failure on SQL Server (sqlsrv driver) Mar 20, 2018
The regression was introduced by 2b8c40d.

Fixes doctrine#3060.
Use a wrapped PDO Statement instead of a custom class for `pdo_sqlsrv` since `PDOSqlsrv\Statement` doesn't extend `PDOStatement` anymore.
@morozov morozov changed the title Fixed build failure on SQL Server (sqlsrv driver) Fixed build failure on SQL Server Mar 20, 2018
@Ocramius Ocramius added this to the 2.7.0 milestone Mar 20, 2018
@Majkl578
Copy link
Contributor

That fatal error on Travis is #3049. @carusogabriel was about to investigate, not sure how far he got. Imho SF PHPUnit bridge related.

@carusogabriel
Copy link
Contributor

@Majkl578 Thanks for remember me, I have forgot to look at this. Gonna look ASAP to figure out what is going wrong 👨🏻‍💻

@morozov
Copy link
Member Author

morozov commented Mar 20, 2018

@Ocramius I've restarted the AppVeyor build, all green now.

@Ocramius Ocramius self-assigned this Mar 20, 2018
@Ocramius
Copy link
Member

Aaaaaand 🚢

@Ocramius Ocramius merged commit 274e5ec into doctrine:develop Mar 20, 2018
@morozov morozov deleted the issues/3060 branch April 19, 2018 20:15
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants