fix(PostgreSQL omit dropped columns in getListTableColumnsSQL (pg_att… #6249
Conversation
…ribute table) to avoid ........pg.dropped.x....... Signed-off-by: Kamil Michalak <k.michalak@kstudio.pl>
|
Thank you. Please add a functional test that covers your change. |
…ribute table) to avoid ........pg.dropped.x....... - test Signed-off-by: Kamil Michalak <k.michalak@kstudio.pl>
…ribute table) to avoid ........pg.dropped.x....... - test fix Signed-off-by: Kamil Michalak <k.michalak@kstudio.pl>
…ribute table) to avoid ........pg.dropped.x....... - test fix Signed-off-by: Kamil Michalak <k.michalak@kstudio.pl>
|
@derrabus please review. |
| public function testPgSqlPgAttributeTable(): void | ||
| { | ||
| $platform = $this->connection->getDatabasePlatform(); | ||
|
|
||
| if (!$platform instanceof PostgreSQLPlatform) { | ||
| self::markTestSkipped('Test does work on PostgreSQL only.'); | ||
| } | ||
|
|
||
| try { | ||
| $this->connection->executeQuery('Select attisdropped from pg_attribute Limit 1')->fetchOne(); | ||
| } catch (Throwable $e) { | ||
| self::fail("Column attisdropped not exists in pg_attribute table"); | ||
| } | ||
| } |
There was a problem hiding this comment.
What is the purpose of this test?
|
What is the status here? I have now also stumbled across this bug and the changes in this pull request have fixed it locally. Is the PR still in development? |
Yes, please do that. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@Vision42 Did you find some time to take on this PR? |
|
@derrabus Is there a timeline for the merger of this pull request? |
No. It's incomplete and obviously nobody's working on it. |
|
@derrabus |
|
Well, the CI is red and the comments from my last review haven't been addressed. What do you want me to clarify? |
…ribute table) to avoid ........pg.dropped.x.......
Summary
Avoid fetching deleted columns for tables structure