Fix connection setup example in PrimaryReadReplicaConnection
#6253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sora Morimoto <sora@morimoto.io>
SenseException
approved these changes
Jan 4, 2024
derrabus
added a commit
that referenced
this pull request
Jan 18, 2024
* 3.7.x: Fix connection setup example in `PrimaryReadReplicaConnection` (#6253) PHPStan 1.10.56, PHPUnit 9.6.15, PHPCS 3.8.1 (#6263) Switch to absolute paths Indent explanation under toctree Use different toctrees for different sections PHP CodeSniffer 3.8.0 (#6238) Allow Symfony 7 in require-dev (#6148)
smorimoto
deleted the
fix-connection-setup-example-in-primaryreadreplicaconnection
branch
derrabus
added a commit
to derrabus/dbal
that referenced
this pull request
Jan 20, 2024
* 3.8.x: Fix deprecation message Parameter::STRING -> ParameterType::STRING (doctrine#6264) Fix connection setup example in `PrimaryReadReplicaConnection` (doctrine#6253) PHPStan 1.10.56, PHPUnit 9.6.15, PHPCS 3.8.1 (doctrine#6263) Switch to absolute paths Indent explanation under toctree Use different toctrees for different sections PHP CodeSniffer 3.8.0 (doctrine#6238) Allow Symfony 7 in require-dev (doctrine#6148)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To match other setup examples, etc.