Remove default value for all-or-nothing option to avoid triggering deprecation notice #1380
Conversation
| @@ -388,8 +388,8 @@ public static function allOrNothing(): Generator | |||
| yield [true, ['--all-or-nothing' => 0], false]; | |||
| yield [true, ['--all-or-nothing' => '0'], false]; | |||
|
|
|||
| yield [true, [], true]; | |||
| yield [false, [], false]; | |||
| yield [true, [], true, false]; | |||
There was a problem hiding this comment.
I'm confused on why this test is failing. I should look into it later. Any guidance welcomed 😃
There was a problem hiding this comment.
I faintly remember this notprovided is here for a reason. Can you look through the history of commits/PRs/issues to find it?
There was a problem hiding this comment.
@gaetan-petit I made an alternative PR with these test changes.
TL;DR as part of the deprecation mechanism, I overlooked checking that the deprecation was not thrown. I adjusted the logic as well to achieve the desired result. Please give a review and point out if there's any flaw in the logic changes.
cc @greg0ire feel free to merge my alternative PR if it's ok for you.
There was a problem hiding this comment.
@agustingomes indeed your pr is a better solution. I am closing this one.
|
closing in favor of #1381 |
Summary
Since 3.7 all-or-nothing option triggers a deprecation notice but
\Doctrine\Migrations\Tools\Console\Command\MigrateCommand::configuredefines a default value tonotprovidedwhich triggers the notice.