GH-1379: Improve Deprecation thrown check + logic #1381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately as part of the previous improvement to determine whether a deprecation is thrown, validating that the deprecation was not thrown ended up not being added explicitly. In addition, adds the explicit expectation of not throwing the deprecation whenever the `--all-or-nothing` is not indicated, which was the root cause originating the issue.
agustingomes
force-pushed
the
GH-1379/improve-deprecation-expectation-check
branch
from
642914a
to
f726a5f
Compare
This was referenced Nov 30, 2023
greg0ire
approved these changes
Dec 4, 2023
SenseException
approved these changes
Dec 4, 2023
|
Thanks @agustingomes ! |
agustingomes
deleted the
GH-1379/improve-deprecation-expectation-check
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately as part of the previous improvement to determine whether a deprecation is thrown, validating that the deprecation was not thrown ended up not being added explicitly.
In addition, adds the explicit expectation of not throwing the deprecation whenever the
--all-or-nothingis not indicated, which was the root cause originating the issue.Summary
When the deprecation was added, the check whether the deprecation is NOT triggered was missing. This PR should solve the underlying issue.