Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(composer): Allow PHPUnit 9 and Doctrine Instantiator 2 #844

Merged
merged 2 commits into from
May 5, 2023

Conversation

scyzoryck
Copy link

Hello!

schmittjoh/serializer are requiring as a dev dependency this package. To run all tests with doctrine/instantiator in version 2, we need to also allow this dependency here. It looks like there is no backward incompatibilities between them - test passed on my local env with jackrabbit.
I also needed to bump PHPUnit to 9.x - in that version it produces some deprecation notices but it looks like the replacement method will be added in PHP 10.1. As example:

assertObjectHasAttribute() is deprecated and will be removed in PHPUnit 10. Refactor your test to use assertObjectHasProperty() (PHPUnit 10.1.0+) instead.

Best, scyzoryck.

Copy link
Member

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! lets see if the gitlab-ci agrees and if so, we can merge this.

note that phpcr-odm 2 is not released yet, i need to find time to wrap up the phpcr-odm bundle to check if there are any remaining issues. i hope to release sometime this month.

composer.json Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
@dbu dbu merged commit cbbaa2f into doctrine:2.x May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants