Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modernize php code #865

Merged
merged 1 commit into from
Jan 15, 2024
Merged

modernize php code #865

merged 1 commit into from
Jan 15, 2024

Conversation

dbu
Copy link
Member

@dbu dbu commented Jan 15, 2024

No description provided.

@dbu dbu force-pushed the modernize-code branch 5 times, most recently from a5c4988 to 2234552 Compare January 15, 2024 09:40
@dbu dbu merged commit 970e074 into 2.x Jan 15, 2024
16 checks passed
@dbu dbu deleted the modernize-code branch January 15, 2024 10:30
@l-you
Copy link

l-you commented Jan 17, 2024

@dbu Great job! Thank you so much!
Which stages remain to release phpcr-odm 2.0 ?

@dbu
Copy link
Member Author

dbu commented Jan 17, 2024

honestly mostly stage fright :D

i just tagged https://github.com/doctrine/phpcr-odm/releases/tag/2.0.0-beta2

if you have an application with phpcr-odm, it would be great if you can try the beta2 and report on any issues. we seem to never have started an UPGRADE.md but at least the changelog should explain a bit what needs to be done. if there are BC breaks that are missing, i am also glad if you can report those.

@llupa
Copy link

llupa commented Feb 19, 2024

@dbu hey!

honestly mostly stage fright :D

Totally get this, but since this is the internet 😄 do you have any feeling when would you move this forward?
I am pinging because of this: FriendsOfSymfony/FOSElasticaBundle#1933

@dbu
Copy link
Member Author

dbu commented Feb 19, 2024

we are currently analyzing the last couple of regressions with sulu, one of the heavy users of the phpcr ecosystem. i hope that by the end of the month, i can tag a stable release.

have you been able to build FOSElasticaBundle with the latest dev-2.x version? that would be a good check to know if we break anything for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants