Move initialization to the constructor #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
force-pushed
the
init-to-construct
branch
from
7fbbbdb to
1db8366
Compare
|
I think you forgot to add the call in the constructor... am I right? |
|
No, it's just the diff that is confusing. I move the entirety of |
|
Then there is a small bug. |
|
Oh right! Good thing we have reviews 😅 |
Since this class no longer uses statism, we have state and we can initialize it in the constructor.
greg0ire
force-pushed
the
init-to-construct
branch
from
1db8366 to
65159dd
Compare
goetas
approved these changes
Mar 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this class no longer use statism, we have state and we can
initialize it in the constructor.