Skip to content

fix: upgrade git-url-parse to fix a parsing issue #1296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2019
Merged

fix: upgrade git-url-parse to fix a parsing issue #1296

merged 1 commit into from
Nov 4, 2019

Conversation

ggrossetie
Copy link
Contributor

resolves #1295

tmcw
tmcw approved these changes Nov 4, 2019
View reviewed changes
Copy link
Member

@tmcw tmcw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tmcw tmcw merged commit 344e804 into documentationjs:master Nov 4, 2019
@ggrossetie
Copy link
Contributor Author

Thanks, that was quick!
And the fix is already available in a release 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmcw tmcw tmcw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Link to source is invalid when using ssh remote git@github.com:owner/name.git
2 participants
@ggrossetie @tmcw