-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full hierarchy support #177
Conversation
In the last Markdown refactor, markdown_ast does nested children same as HTML did. Though they'll both need to handle the new tree structure. |
Do you have a preference for the |
I think they need to be unflattened -- in order to enable efficient traversal, these are objects keyed by name (not arrays), and you can have a class with a static member and an instance member with the same name, for instance. |
These changes are breaking assumptions in the multisignature test:
I'm not really sure this should be supported. |
I'm seeing now that events should not be included in a separate scope category alongside static, instance, and inner. Instead they're given a special |
Okay, after much massaging, I decided that not much has to change after all. The changes now are pleasingly contained:
👀 @tmcw |
👍 lgtm |
This is a pretty big lift:
events
property moving tomembers.event
)Refs #111.