Skip to content

Ignore node_modules folder in git #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2016
Merged

Ignore node_modules folder in git #326

merged 1 commit into from
Jan 7, 2016

Conversation

danez
Copy link
Contributor

@danez danez commented Jan 5, 2016

No description provided.

@tmcw
Copy link
Member

tmcw commented Jan 7, 2016

Personally I'm in favor of global .gitignore files expressing this and not repeating this kind of rule in every repo, but this seems to be the trend so ¯_(ツ)_/¯

tmcw added a commit that referenced this pull request Jan 7, 2016
Ignore node_modules folder in git
@tmcw tmcw merged commit 39b0ae4 into documentationjs:master Jan 7, 2016
@danez
Copy link
Contributor Author

danez commented Jan 8, 2016

I also think that some other projects have way to many ignores in the project. Everything that is dependent on the OS or on the IDE/editor should not go there but be ignored globally, IMHO. But for nodemodules I think it's part of the project and therefore fits good in this ignore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants