fix: @name tag disconnects comment #897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous support for @name tags suppressing inference from surrounding code was ad-hoc and incomplete. This commit makes a @name tag (or a tag acting as a @kind/@name shorthand combo, like @function) detach the `ast` field from the comment context, so that the surrounding code will be universally ignored per the JSDoc spec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous support for
@nametags suppressing inference from surrounding code was ad-hoc and incomplete. This commit makes a@nametag (or a tag acting as a@kind/@nameshorthand combo, like@function) detach theastfield from the comment context, so that the surrounding code will be universally ignored per the JSDoc spec.Close #896