Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifying Logger.new shift_age option default #64

Closed
spacemunkay opened this issue Mar 16, 2016 · 3 comments
Closed

Specifying Logger.new shift_age option default #64

spacemunkay opened this issue Mar 16, 2016 · 3 comments

Comments

@spacemunkay
Copy link

http://ruby-doc.org/stdlib-2.3.0/libdoc/logger/rdoc/Logger.html#new-method

From only looking at the docs, it's not obvious what the default value is for shift_age, nor what value disables the option. The only way to find out is to look at the code itself.

Can submit a PR with the following adjustment: trunk...spacemunkay:specify-logger-shift-age-default

@davydovanton
Copy link
Member

hello @spacemunkay, nice catch! 👍
I think PR will be great.

@spacemunkay
Copy link
Author

@davydovanton No problem!

@spacemunkay
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants