-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creating CSM ISDs #90
Comments
It looks like the notebooks haven't been updated since the switch to the new ISD format in USGSCSM 1.5. The fix for this is to remove the formatter argument in the ale.loads call. The "usgscsm" and "isis" formatters are there for backwards compatibility, the default "ale" formatter is intended for use with USGSCM 1.5+ and ISIS 4.2+ |
Jesse, thank you. It does not work though, either no formatter, or with the 'isis' or 'ale' formatter. I get errors like: KeyError: 'IsisCube' I also tried things like: from ale.formatters.formatter import to_isd also with no luck. I used the precise notebook, with ISIS 4.4. I tried ISIS 3.7 too, but after I synched up the ISIS data, I can no longer get ISIS 3.7 to work so I am not sure I did that experiment well with ISIS 3.7. Any thoughts? |
@oleg-alexandrov Can you set |
If desired to reproduce this, likely it is best to create a fresh install of the latest dependencies with conda. (When doing that, I also got some error about pvl at some point, it seems that this package changed a function's name, but other packages that depend on it still seek the old name. ) |
Here it is is. Lots of repetitive stuff. It appears to do some kind of exhaustive search failing each time.
|
Okay here's the issue:
scipy changed their rotation to/from rotation matrix methods in 1.6.0. This was fixed in DOI-USGS/ale#399 but hasn't been released yet. If you're working with ALE <= 0.8.5 then you can fix this by installing scipy < 1.6.0. I'm going to close this issue as it will be fixed once ALE 0.8.6 comes out. |
I am using the example at https://github.com/USGS-Astrogeology/knoten/blob/master/examples/mro_ctx_isis_cmp.ipynb
to create ISD json files. I fetched knoten and am using ISIS 4.4.0, the latest.
Things work, except for the fact that the lines:
kernels = ale.util.generate_kernels_from_cube(cub_loc, expand=True)
usgscsm_str = ale.loads(fileName, props={'kernels': kernels}, formatter="usgscsm", verbose=False)
csm_isd = os.path.splitext(cub_loc)[0] + '.json'
with open(csm_isd, 'w') as isd_file:
isd_file.write(usgscsm_str)
creates .json files that are compatible with libusgscsm.so.1.4.0 and not with libusgscsm.so.1.5.1
That, despite my conda environment having
ale 0.8.5 py37h2527ec5_1 conda-forge
csm 3.0.3.3 hc9558a2_0 conda-forge
csmapi 1.0.1 py37h99015e2_0 conda-forge
usgscsm 1.5.1 h4bd325d_0 conda-forge
Is the ale package able to create the latest CSM .json files?
Or maybe I am doing something wrong.
The text was updated successfully, but these errors were encountered: