Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn on deploy if there is a published port #4662

Closed
cmer opened this issue Jun 25, 2021 · 2 comments
Closed

Warn on deploy if there is a published port #4662

cmer opened this issue Jun 25, 2021 · 2 comments

Comments

@cmer
Copy link

cmer commented Jun 25, 2021

  • Need to warn if someone scales the app up (or even has more than one process type, since docker options are global)
  • if they dont have checks disabled
@josegonzalez
Copy link
Member

Checks only need to be disabled for the web process, so if they are either disabled globally or disabled for web, thats good enough.

We'll probably want to add the warning to scheduler-deploy-process. We can check in there if there is a -p|--publish flag with an argument or -P|--publish-all flag. If so, we'll add the warning if the process count is greater than 1.

Additionally, we will add the warning if checks aren't disabled. If both conditions aren't satisfied, we'll only warn once (but will note both reasons).

@josegonzalez
Copy link
Member

Closing as there is a pull request open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants