-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebase the plugin on grok #5
Conversation
This implements a mechanism that transforms our current references into search terms understood by Grok. Using the API we can even check if there's any hits (ideally it should be exactly one)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will try it later here some first notes.
In general it works. Of course, Gork works a bit different, so different usage choices are needed. Not found:
General point for discussion:
|
I'm a bit puzzeling, if there is an simple syntax to:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I check this another time. I think it can work well.
Remaining case which I cannot explain is [[xref>$USERINFO]]
. Therfore, no suggestions for improvement.
[[xref>$_filename]]
was not working due to case-sensitivity, must be [[xref>$_fileName]]
.
[[xref>DokuWiki_Auth_Plugin]]
is also not working, but that is because it is an alias. Therefore, it is logic OpenGrok is not recognizing it. That can be workaround with [[codesearch>DokuWiki_Auth_Plugin]]
.
I did a proposal for supporting arguments in the brackets of functions.
Further fine for me to merge and publish :-)
Co-authored-by: Gerrit Uitslag <klapinklapin@gmail.com>
Co-authored-by: Gerrit Uitslag <klapinklapin@gmail.com>
Co-authored-by: Gerrit Uitslag <klapinklapin@gmail.com>
Co-authored-by: Gerrit Uitslag <klapinklapin@gmail.com>
Co-authored-by: Gerrit Uitslag <klapinklapin@gmail.com>
This makes the plugin use Grok and codesearch.dokuwiki.org instead on relying on the no longer maintained phpxref.
I think it should work relatively well as a drop in replacement.
@Klap-in would be great if you could have a quick look before I merge this and bring it online.
related to #2 #3 and #4