-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wiimote: Reconnect a disconnected Wiimote when a button is pressed. #2724
Wiimote: Reconnect a disconnected Wiimote when a button is pressed. #2724
Conversation
…utton is pressed.
bea15ec
to
e462422
Compare
Okay, if someone wants to test this now, go for it, as far as I can tell it works as it should. Implementation notes:
|
And here is the same thing for real Wiimotes, too! |
ef178d2
to
4be80b3
Compare
Behavior is fine, everything works just like a Real Wii with connecting emulated Wiimotes now (at least, the same as it would be for a synced Wiimote.) My only issue is that it never lets the user know when a Wiimote is forcefully disconnected, but, honestly? That isn't really worth blocking and was already an issue in the emulator. LGTM. |
…essed. Where disconnected is defined as: The real physical device is still connected to the PC, but the emulated Wii sees the Wiimote as disconnected.
…ctWiimote() directly, dispatch an event that will call it for us in the GUI thread. This eliminates a possible stutter/short freeze that can happen during PowerPC::Pause().
4be80b3
to
935292c
Compare
FYI, the notification about a Wiimote being disconnected should probably be added around here. Different PR territory though since getting a userfriendly message out of that seems harder than expected. |
This is working nicely with my real wiimote. I can reconnect on Metroid Prime Trology and the Wii Sports resort WM+ video just fine. Reconnecting after a timeout works fine as well(only tested in Resident Evil 4). I can't say anything about the implementation though, it's a bit over my head. |
Is this still WIP? It came here to kick ass and chew bubble gum, and it's all out of ass. Seriously though, I tested it, I love it, this is the best thing ever made. |
Nah this is done, unless someone really wants reconnect-on-extension-press too. |
Hm, reconnect on classic controller button press might be nice. Not sure about the rest of the extensions, like guitars and whatnot. |
We can always throw another PR for that; I'd rather get that merged sooner than later |
…ton-press Wiimote: Reconnect a disconnected Wiimote when a button is pressed.
This reconnects an emulated Wiimote to the emulator when a key or button mapped to one of the Wiimote's buttons is pressed, similar to how a real Wiimote attempts to connect to the last known Wii when you push something on it. Mainly fixes the inconvenience of having to manually press Reconnect Wiimote after a few minutes of inactivity.
Still has a problem at the moment where a single button press can send multiple "reconnect me!" requests (presumably due to the update frequency of Wiimotes being higher than a typical game's framerate) which can freeze up the emulator for a second but technically works.