DiscScrubber: Turn into a class #3352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| u64 CurrentOffset = m_BlockCount * m_BlockSize; | ||
| u64 i = CurrentOffset / CLUSTER_SIZE; | ||
| u64 current_offset = m_block_count * m_block_size; | ||
| u64 i = current_offset / CLUSTER_SIZE; | ||
|
|
||
| size_t ReadBytes = 0; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
|
lioncash
force-pushed
the
scrub
branch
2 times, most recently
from
8224c1f
to
ade5e69
Compare
|
Rebase and this will get through too. |
|
@lioncash Reminder that this needs a rebase. |
|
@Fallcrest I know, thanks. |
Allows potential multiple scrubbers to run at once. Also gets rid of the need to explicitly clean up resources.
JosJuice
reviewed
Jan 4, 2017
| @@ -20,160 +20,91 @@ | |||
|
|
|||
| namespace DiscIO | |||
| { | |||
| namespace DiscScrubber | |||
| { | |||
| #define CLUSTER_SIZE 0x8000 | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gets things out of global lifetime scope and gets rid of the need to explicitly clean up things when done using an instance of it, since object destructors can do it themselves upon going out of scope.
This change is