DSPTables: Hide remaining opcode tables #4757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lioncash
force-pushed
the
dsptables
branch
2 times, most recently
from
28a04fa
to
d98b7b7
Compare
degasus
reviewed
Jan 26, 2017
| return FindOpInfoByName(name); | ||
|
|
||
| return FindExtOpInfoByName(name); | ||
| }(); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
All opcode tables are now internal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hides the main information opcodes from being seen in external scope and presents an API for using the tables.
One consideration that could also be preferable, is that the
OpcodeTypeenum could be moved to DSPTables and the Find functions can be reduced from four to two functions by combining both find-by-opcode functions and find-by-name functions into one another with anOpcodeTypeparameter to determine which table to look through. I kept them separately for the time being in case the separation is preferred.