CMake: re-run to get version information when .git/HEAD changes #4841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Orphis
reviewed
Feb 7, 2017
CMakeLists.txt
Outdated
| @@ -918,6 +918,7 @@ else() | |||
| set(DOLPHIN_WC_IS_STABLE "0") | |||
| endif() | |||
|
|
|||
| set_property(DIRECTORY APPEND PROPERTY CMAKE_CONFIGURE_DEPENDS "${CMAKE_SOURCE_DIR}/.git/HEAD") | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Fixes an issue where Dolphin's revision information could be incorrect when: 1) CMake was run while HEAD was at commit A 2) HEAD was set to commit B, which didn't have differences from A that would cause CMake to be re-run This does not fix the issue with incorrect information about whether Dolphin was built from a dirty working tree or not.
ligfx
force-pushed
the
accuratescmrev
branch
3 times, most recently
from
eafdba9
to
9502f32
Compare
Orphis
approved these changes
Feb 7, 2017
lioncash
approved these changes
Feb 7, 2017
ligfx
added a commit
to ligfx/dolphin
that referenced
this pull request
Feb 7, 2017
In an oversight, PR dolphin-emu#4841 didn't handle committing to a branch.
ligfx
added a commit
to ligfx/dolphin
that referenced
this pull request
Feb 7, 2017
In an oversight, PR dolphin-emu#4841 didn't handle committing to a branch.
ligfx
added a commit
to ligfx/dolphin
that referenced
this pull request
Feb 7, 2017
In an oversight, PR dolphin-emu#4841 didn't handle committing to or amending a branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where Dolphin's revision information could be incorrect
when:
that would cause CMake to be re-run
This does not fix the issue with incorrect information about whether
Dolphin was built from a dirty revision or not.